task: Add PHPStan

andreaswolf · Mar 8, 2024 · 6310bc9 · 6310bc9
1 parent defe494
commit 6310bc9
Show file tree

Hide file tree

Showing 10 changed files with 36 additions and 3 deletions.
diff --git a/.github/workflows/lint_test_pull_requests.yaml b/.github/workflows/lint_test_pull_requests.yaml
@@ -15,6 +15,8 @@ jobs:
  command: 'style:php'
  - name: Composer normalize
  command: 'normalize --dry-run'
+ - name: PHPStan
+ command: analyze:php
  directory: ['extension-installer', 'fractor', 'fractor-xml', 'typo3-fractor']
  name: ${{ matrix.composer-command.name }}/${{ matrix.directory }}
  defaults:

diff --git a/extension-installer/composer.json b/extension-installer/composer.json
@@ -17,6 +17,7 @@
  "require-dev": {
  "composer/composer": "^2.7",
  "ergebnis/composer-normalize": "^2.42",
+ "phpstan/phpstan": "^1.10",
  "symplify/easy-coding-standard": "^12.1"
  },
  "autoload": {
@@ -34,6 +35,7 @@
  "class": "a9f\\FractorExtensionInstaller\\InstallerPlugin"
  },
  "scripts": {
+ "analyze:php": "phpstan analyze",
  "style:php": "ecs"
  }
 }
diff --git a/extension-installer/phpstan.neon b/extension-installer/phpstan.neon
@@ -0,0 +1,5 @@
+parameters:
+ level: 8
+
+ paths:
+ - src/
diff --git a/fractor-xml/composer.json b/fractor-xml/composer.json
@@ -47,6 +47,7 @@
  "sort-packages": true
  },
  "scripts": {
+ "analyze:php": "phpstan analyze",
  "style:php": "ecs"
  }
 }
diff --git a/fractor-xml/phpstan.neon b/fractor-xml/phpstan.neon
@@ -0,0 +1,6 @@
+parameters:
+ level: 8
+
+ paths:
+ - src/
+ - tests/
diff --git a/fractor/composer.json b/fractor/composer.json
@@ -20,7 +20,7 @@
  },
  "require-dev": {
  "ergebnis/composer-normalize": "^2.42",
- "phpstan/phpstan": "1.10",
+ "phpstan/phpstan": "^1.10",
  "phpunit/phpunit": "^10.5",
  "symplify/easy-coding-standard": "^12.1"
  },
@@ -44,6 +44,7 @@
  "sort-packages": true
  },
  "scripts": {
+ "analyze:php": "phpstan analyze",
  "style:php": "ecs"
  }
 }
diff --git a/fractor/phpstan.neon b/fractor/phpstan.neon
@@ -0,0 +1,6 @@
+parameters:
+ level: 8
+
+ paths:
+ - src/
+ - tests/
diff --git a/fractor/src/Configuration/FractorConfig.php b/fractor/src/Configuration/FractorConfig.php
@@ -8,7 +8,7 @@
 
 final class FractorConfig extends ContainerBuilder
 {
- /** @var non-empty-list<non-empty-string> */
+ /** @var list<non-empty-string> */
  private array $paths = [];
 
  /**
@@ -34,7 +34,7 @@ public function setPaths(array $paths): self
  }
 
  /**
- * @return non-empty-list<non-empty-string>
+ * @return list<non-empty-string>
  */
  public function getPaths(): array
  {
@@ -58,6 +58,9 @@ public function getFileProcessors(): array
  return $this->processors;
  }
 
+ /**
+ * @param list<non-empty-string> $extensions
+ */
  public function setFileExtensions(array $extensions): self
  {
  $this->fileExtensions = $extensions;

diff --git a/typo3-fractor/composer.json b/typo3-fractor/composer.json
@@ -46,6 +46,7 @@
  "sort-packages": true
  },
  "scripts": {
+ "analyze:php": "phpstan analyze",
  "style:php": "ecs"
  }
 }
diff --git a/typo3-fractor/phpstan.neon b/typo3-fractor/phpstan.neon
@@ -0,0 +1,6 @@
+parameters:
+ level: 8
+
+ paths:
+ - src/
+ - tests/