Improve typing

docs/Experiment.md

@@ -267,7 +267,7 @@ This is the percentual chance that a new user will be included in the experiment
 **Description**
 
 ```php
-public setAllocation (int $percent)
+public setAllocation (int|string $percent)
 ```
 
 Set experiment allocation 
@@ -276,7 +276,7 @@ This is the percentual chance that a new user will be included in the experiment
 
 **Parameters**
 
-* `(int) $percent`
+* `(int|string) $percent`
 
 **Return Values**
 
@@ -300,4 +300,4 @@ Return a Result instance from the current experiment
 
 **Return Values**
 
-`Result`
+`Result`

docs/Group.md

@@ -152,14 +152,14 @@ Get group views
 **Description**
 
 ```php
-public setViews (int $views)
+public setViews (int|string $views)
 ```
 
 Set group views 
 
 **Parameters**
 
-* `(int) $views`
+* `(int|string) $views`
 
 **Return Values**
 
@@ -192,14 +192,14 @@ Get number of conversions for the group
 **Description**
 
 ```php
-public setConversions (int $conversions)
+public setConversions (int|string $conversions)
 ```
 
 Set number of conversions for the group 
 
 **Parameters**
 
-* `(int) $conversions`
+* `(int|string) $conversions`
 
 **Return Values**
 
@@ -334,14 +334,14 @@ Returns 0 for control, 1 for variation and null when type is unknown
 **Description**
 
 ```php
-public isType (int $type)
+public isType (int|string $type)
 ```
 
-Get whether the variation is a specific type 
+Get whether the variation is a specific type (0 or 1)
 
 **Parameters**
 
-* `(int) $type`
+* `(int|string) $type`
 
 **Return Values**
 
@@ -354,14 +354,14 @@ Get whether the variation is a specific type
 **Description**
 
 ```php
-public setType (int $type)
+public setType (int|string $type)
 ```
 
-Set group type 
+Set group type (0 or 1)
 
 **Parameters**
 
-* `(int) $type`
+* `(int|string) $type`
 
 **Return Values**
 
@@ -445,4 +445,4 @@ Define the group as the variation
 
 **Return Values**
 
-`self`
+`self`

docs/Result.md

@@ -42,14 +42,14 @@ Get the specified minimum confidence
 **Description**
 
 ```php
-public setMinimumConfidence (float $confidence)
+public setMinimumConfidence (float|string $confidence)
 ```
 
 Set the minimum confidence 
 
 **Parameters**
 
-* `(float) $confidence`
+* `(float|string) $confidence`
 
 **Return Values**
 
@@ -82,14 +82,14 @@ Get the specified minimum detectable effect
 **Description**
 
 ```php
-public setMinimumDetectableEffect (float $effect)
+public setMinimumDetectableEffect (float|string $effect)
 ```
 
 Set the minimum detectable effect 
 
 **Parameters**
 
-* `(float) $effect`
+* `(float|string) $effect`
 
 **Return Values**
 
@@ -263,4 +263,4 @@ Get complete results
 
 **Return Values**
 
-`object`
+`object`

docs/Token.md

@@ -123,7 +123,7 @@ Set tracking token value
 **Description**
 
 ```php
-public setCookie (string|null $value, int|null $expires)
+public setCookie (string|null $value, int|string|null $expires)
 ```
 
 Set tracking cookie with the token name and value 
@@ -134,7 +134,7 @@ This sends a cookie to the users browser with the configured settings (and if pa
 
 * `(string|null) $value`
 : Defaults to configured value 
-* `(int|null) $expires`
+* `(int|string|null) $expires`
 : Defaults to current time plus configured max age
 
 **Return Values**
@@ -161,4 +161,4 @@ This sends a cookie to the users browser with the configured settings, but with
 
 **Return Values**
 
-`self`
+`self`

docs/User.md

@@ -88,14 +88,14 @@ Get all user experiments
 **Description**
 
 ```php
-public hasExperiment (Experiment|int $experiment)
+public hasExperiment (Experiment|int|string $experiment)
 ```
 
 Return whether the user has an experiment in the list, regardless of whether the user actually is part of it 
 
 **Parameters**
 
-* `(Experiment|int) $experiment`
+* `(Experiment|int|string) $experiment`
 : Experiment instance or ID 
 
 **Return Values**
@@ -109,16 +109,16 @@ Return whether the user has an experiment in the list, regardless of whether the
 **Description**
 
 ```php
-public isParticipant (Experiment|int $experiment, int|null $group)
+public isParticipant (Experiment|int|string $experiment, int|string|null $group)
 ```
 
 Return whether the user is a participant of an experiment, and optionally, part of a specific group
 
 **Parameters**
 
-* `(Experiment|int) $experiment`
+* `(Experiment|int|string) $experiment`
 : Experiment instance or ID 
-* `(int|null) $group`
+* `(int|string|null) $group`
 : Group type (0 or 1) 
 
 **Return Values**
@@ -132,14 +132,14 @@ Return whether the user is a participant of an experiment, and optionally, part
 **Description**
 
 ```php
-public inControl (Experiment|int $experiment)
+public inControl (Experiment|int|string $experiment)
 ```
 
 Return whether the user belongs to the control group of an experiment
 
 **Parameters**
 
-* `(Experiment|int) $experiment`
+* `(Experiment|int|string) $experiment`
 : Experiment instance or ID 
 
 **Return Values**
@@ -153,14 +153,14 @@ Return whether the user belongs to the control group of an experiment
 **Description**
 
 ```php
-public inVariation (Experiment|int $experiment)
+public inVariation (Experiment|int|string $experiment)
 ```
 
 Return whether the user belongs to the variation group of an experiment
 
 **Parameters**
 
-* `(Experiment|int) $experiment`
+* `(Experiment|int|string) $experiment`
 : Experiment instance or ID 
 
 **Return Values**
@@ -174,7 +174,7 @@ Return whether the user belongs to the variation group of an experiment
 **Description**
 
 ```php
-public addExperiment (Experiment|int $experiment, Group|null $group, bool $viewed, bool $converted)
+public addExperiment (Experiment|int|string $experiment, Group|null $group, bool $viewed, bool $converted)
 ```
 
 Add an experiment to the users list of experiments 
@@ -183,7 +183,7 @@ If no group is set, the experiment is added to to list without the user being as
 
 **Parameters**
 
-* `(Experiment|id) $experiment`
+* `(Experiment|id|string) $experiment`
 : Experiment instance or ID
 * `(Group|null) $group`
 * `(bool) $viewed`
@@ -242,14 +242,14 @@ If the experiments coverage is below 100, it's percentage value will be used to
 **Description**
 
 ```php
-public hasViewed (int $id)
+public hasViewed (int|string $id)
 ```
 
 Get whether a user has viewed a specific experiment 
 
 **Parameters**
 
-* `(int) $id`
+* `(int|string) $id`
 : Experiment ID 
 
 **Return Values**
@@ -263,14 +263,14 @@ Get whether a user has viewed a specific experiment
 **Description**
 
 ```php
-public setViewed (int $id, bool $viewed)
+public setViewed (int|string $id, bool $viewed)
 ```
 
 Set whether a user has viewed a specific experiment 
 
 **Parameters**
 
-* `(int) $id`
+* `(int|string) $id`
 : Experiment ID 
 * `(bool) $viewed`
 
@@ -285,14 +285,14 @@ Set whether a user has viewed a specific experiment
 **Description**
 
 ```php
-public hasConverted (int $id)
+public hasConverted (int|string $id)
 ```
 
 Get whether a user has converted in a specific experiment 
 
 **Parameters**
 
-* `(int) $id`
+* `(int|string) $id`
 : Experiment ID 
 
 **Return Values**
@@ -306,15 +306,15 @@ Get whether a user has converted in a specific experiment
 **Description**
 
 ```php
-public setConverted (int $id, bool $converted)
+public setConverted (int|string $id, bool $converted)
 ```
 
 Set whether a user has converted in a specific experiment 
 
 **Parameters**
 
-* `(int) $id`
+* `(int|string) $id`
 : Experiment ID 
 * `(bool) $converted`
 
-**Return Values**
+**Return Values**

src/Experiment.php

@@ -115,11 +115,11 @@ public function setName($name)
  */
  private function mapGroup($key)
  {
- if (is_string($key)) {
+ if (!is_numeric($key)) {
  $index = false;
 
  foreach ($this->groups as $i => $group) {
- if ($group->getName() == $key) {
+ if ($group->getName() === $key) {
  $index = $i;
  }
  }
@@ -131,7 +131,7 @@ private function mapGroup($key)
  return $index;
  }
 
- return $key;
+ return (int)$key;
  }
 
  /**
@@ -252,12 +252,14 @@ public function getAllocation()
  * 
  * This is the percentual chance that a new user will be included in the experiment
  *
- * @param int $percent
+ * @param int|string $percent
  * 
  * @return self
  */
  public function setAllocation($percent)
  {
+ $percent = (int)$percent;
+
  if ($percent < 0 || $percent > 100) {
  throw new \Exception('Invalid $percent (value must be between 0 and 100)');
  }
@@ -276,4 +278,4 @@ public function getResult()
  {
  return new Result($this);
  }
-}
+}