Merge pull request #5 from aglejberman/master

Undefined offset notices fix
andres-montanez · Apr 4, 2016 · 0995864 · 0995864
2 parents ec7b56b + 9b2f06f
commit 0995864
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/Service/UserAgentService.php b/Service/UserAgentService.php
@@ -144,15 +144,17 @@ public function parse($userAgentString)
 
  // A valid Operating System was found
  if ($osId !== null) {
- $osData = $this->data['operating_systems'][$osId];
-
- $userAgent->setOperatingSystemFamily($osData['family']);
- $userAgent->setOperatingSystemName($osData['name']);
- $userAgent->setOperatingSystemUrl($osData['url']);
- $userAgent->setOperatingSystemCompany($osData['company']);
- $userAgent->setOperatingSystemCompanyUrl($osData['url_company']);
- $userAgent->setOperatingSystemIcon($osData['icon']);
- $userAgent->setOperatingSystemInfoUrl($osData['os_info_url']);
+ if (isset($this->data['operating_systems'][$osId])) {
+ $osData = $this->data['operating_systems'][$osId];
+
+ $userAgent->setOperatingSystemFamily($osData['family']);
+ $userAgent->setOperatingSystemName($osData['name']);
+ $userAgent->setOperatingSystemUrl($osData['url']);
+ $userAgent->setOperatingSystemCompany($osData['company']);
+ $userAgent->setOperatingSystemCompanyUrl($osData['url_company']);
+ $userAgent->setOperatingSystemIcon($osData['icon']);
+ $userAgent->setOperatingSystemInfoUrl($osData['os_info_url']);
+ }
  }
 
  // Detect Device by Regular Expression