Plot arcs method #84
Open
Plot arcs method #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimav
commented
Jan 21, 2023
| def plot_arcs_around_goals_on_pitches(pitch_cls): | ||
| fig, axes = plt.subplots(4, 2, figsize=(12, 14)) | ||
| axes = axes.ravel() | ||
| pitch_types = ['statsbomb', 'opta', 'tracab', 'skillcorner', 'wyscout', |
There was a problem hiding this comment.
This is a simplified version of examples/pitch_setup/plot_compare_pitches.py which I was using to make sure I dealt with the subtleties of the different coordinate systems and aspect ratios.
minimav
commented
Jan 21, 2023
Comment on lines
+342
to
+344
| self._draw_arc( | ||
| ax, ymin + self.pad_bottom, x, height, width, theta1=-90, theta2=90, **kwargs | ||
| ) |
There was a problem hiding this comment.
The _draw_arc method on a VerticalPitch switches orientations for you. Due to how I worked out the co-ordinates I have 'undone' the switch in the arguments passed here so that it works out correctly. I was not really sure how to go about this in such a way that this extra switch wouldn't be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've had a go at issue #14 in this PR. I'm not sure if there are existing methods to achieve some of what I do in the methods, let me know if you know of easier ways :)
Below are screenshots of what the example will produce for both pitch orientations, plotting arcs at 5, 10, 20 and 30 metres: