Issue #196 #253
Merged
Issue #196 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic dockables in tab groups now reload properly. This required storing the class-name for the selected tab and all tabs in the group pane. This allows Modern Docking to properly reload. There were also some code changes required to detect when a dockable has failed to load, and to check if it is a dynamic dockable (by attempting to create an instance of the class).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic dockables in tab groups now reload properly. This required storing the class-name for the selected tab and all tabs in the group pane. This allows Modern Docking to properly reload. There were also some code changes required to detect when a dockable has failed to load, and to check if it is a dynamic dockable (by attempting to create an instance of the class).