Skip to content

Commit

Permalink
prep for v19 (#3578)
Browse files Browse the repository at this point in the history
* angular v19 peers
* firebase v11
* bundle schematics, remove unneeded deps
* fix #3556
  • Loading branch information
jamesdaniels authored Nov 20, 2024
1 parent a4faa10 commit a58b329
Show file tree
Hide file tree
Showing 29 changed files with 7,754 additions and 9,766 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
check-latest: false
- name: angular build cache
uses: actions/cache@v3
Expand All @@ -37,9 +37,9 @@ jobs:
id: node_modules_cache
with:
path: ./node_modules
key: ${{ runner.os }}-18-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-20-${{ hashFiles('package-lock.json') }}
restore-keys: |
${{ runner.os }}-18-
${{ runner.os }}-20-
- name: Install deps
if: steps.node_modules_cache.outputs.cache-hit != 'true'
run: |
Expand All @@ -59,7 +59,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
node: ["18", "20"]
node: ["18", "20", "22"]
fail-fast: false
name: Test Node ${{ matrix.node }} (${{ matrix.os }})
steps:
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
check-latest: false
- name: Setup java
uses: actions/setup-java@v3
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
node: ["18"]
node: ["20"]
fail-fast: false
steps:
- name: Checkout
Expand Down Expand Up @@ -206,7 +206,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
registry-url: 'https://registry.npmjs.org'
check-latest: false
- name: 'Download Artifacts'
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ import { } from '@angular/fire/app-check';
<tr>
<td>

#### [Vertex AI](docs/vertexai.md#vertex-ai-preview)
#### [Vertex AI](docs/vertexai.md#vertex-ai)
```ts
import { } from '@angular/fire/vertexai-preview';
import { } from '@angular/fire/vertexai';
```
</td>

Expand Down
6 changes: 3 additions & 3 deletions docs/vertexai.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Next inject `VertexAI` into your component:

```typescript
import { Component, inject } from '@angular/core';
import { VertexAI } from '@angular/fire/vertexai-preview';
import { VertexAI } from '@angular/fire/vertexai';

@Component({ ... })
export class MyComponent {
Expand All @@ -48,6 +48,6 @@ export class MyComponent {

AngularFire wraps the Firebase JS SDK to ensure proper functionality in Angular, while providing the same API.

Update the imports from `import { ... } from 'firebase/vertexai-preview'` to `import { ... } from '@angular/fire/vertexai-preview'` and follow the official documentation.
Update the imports from `import { ... } from 'firebase/vertexai'` to `import { ... } from '@angular/fire/vertexai'` and follow the official documentation.

[Getting Started](https://firebase.google.com/docs/vertex-ai/get-started?platform=web) | [API Reference](https://firebase.google.com/docs/reference/js/vertexai-preview)
[Getting Started](https://firebase.google.com/docs/vertex-ai/get-started?platform=web) | [API Reference](https://firebase.google.com/docs/reference/js/vertexai)
Loading

0 comments on commit a58b329

Please sign in to comment.