Enable building the application with the ESM build system #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
changed the title
The `normalize-path` package was previously imported via a namespace import. However, the ECMAScript specification returns an exotic namespace object from namespace imports which can never be a function. As a result a namespace import can not be called. Since the import is directly called it must be imported As a default import to be ECMAScript compliant. TypeScript by default allows the non-compliant form even though it can result in runtime errors. The TypeScript `esModuleInterop` option (recommended by TypeScript) causes TypeScript to error on non-compliant usage and ensures the correct code is emitted so that the code can be executed and/or bundled in an ESM environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.