-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added github actions to run uiTests #1048
base: develop
Are you sure you want to change the base?
Conversation
4249e80
to
144c01e
Compare
@isabelcosta done can you review ? The tests are failing because the existing tests fail. |
@epicadk is it possible to have this as a separate check on GitHub checks 🤔 to separate build from tests so we know right aways why something is failing. Would you know how to do that? |
Hmm it is but we can also check the details to view which test has failed , and it would also avoid setting up of another Ubuntu system. Let me know how I should proceed. |
0ff04a8
to
6d8a1e2
Compare
@isabelcosta I created a separate workflow using mac-os ( as that is what was recommended in the docs here) I think it is working as expected now please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very aware of how tests are run in Android, but this looks good to me. I saw the additional PR check and I think that looks good separate from the build workflow. I will ask for more reviews on this from the community.
Thank you so much for working on this @epicadk 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested minor changes to observe pas and pushes to master branch as well.
Prs not pas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in comments
I've made the requested changes @isabelcosta @annabauza. : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
I just removed the comments in the yml file. Should I squash the commits? |
No worries. No need for that, I will squash anyways when merging @epicadk :) thank you so much for working on this one 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@epicadk could you please update this branch, not sure if the tests are already fixed 🤔 and if they are not yet fixed, we have to pin community again to help us fix the tests |
Ran the tests locally and they haven't been fixed yet. I'll look into this. Also I had brought this up in a session but sometimes the sessions times out and that is why the tests fail. |
Description
Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.
Fixes #168
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only