Add foreign key options to safe_add_reference (#238)

ankane · Sep 8, 2023 · 405b3ba · 405b3ba
1 parent fa43564
commit 405b3ba
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/lib/strong_migrations/safe_methods.rb b/lib/strong_migrations/safe_methods.rb
@@ -29,11 +29,12 @@ def safe_add_reference(table, reference, *args, **options)
               else
                 (ActiveRecord::Base.pluralize_table_names ? reference.to_s.pluralize : reference).to_sym
               end
-
+
+            foreign_key_opts = foreign_key.is_a?(Hash) ? foreign_key.except(:to_table) : {}
             if reference
-              @migration.add_foreign_key(table, name, column: "#{reference}_id")
+              @migration.add_foreign_key(table, name, column: "#{reference}_id", **foreign_key_opts)
             else
-              @migration.add_foreign_key(table, name)
+              @migration.add_foreign_key(table, name, **foreign_key_opts)
             end
           end
         end

diff --git a/test/migrations/add_reference.rb b/test/migrations/add_reference.rb
@@ -34,6 +34,12 @@ def change
   end
 end
 
+class AddReferenceForeignKeyOnDelete < TestMigration
+  def change
+    add_reference :users, :device, foreign_key: {on_delete: :nullify}, index: false
+  end
+end
+
 class AddReferenceConcurrently < TestMigration
   disable_ddl_transaction!
 

diff --git a/test/safe_by_default_test.rb b/test/safe_by_default_test.rb
@@ -66,6 +66,10 @@ def test_add_reference_foreign_key_to_table
     assert_safe AddReferenceForeignKeyToTable
   end
 
+  def test_add_reference_foreign_key_on_delete
+    assert_safe AddReferenceForeignKeyOnDelete
+  end
+
   def test_add_reference_extra_arguments
     assert_argument_error AddReferenceExtraArguments
   end