Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codecov Configuration to Enable Annotations and Improve Stability #17627

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohitdev06
Copy link

Update Codecov Configuration

This pull request updates the .codecov.yml file to enhance code coverage reporting.

Key Changes:

Enabled Annotations: Provides detailed feedback on coverage changes within pull requests.
Set Coverage Status to Informational: Avoids build failures due to minor coverage fluctuations.

These updates aim to improve code quality and stability by making coverage issues more visible and preventing unnecessary build failures.

Fixes issue #12227 related to coverage fluctuations.

Copy link

welcome bot commented Dec 18, 2024

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there 👋 - thanks for this

I don't like the change to turning annotations on as we disabled those on purpose, they were very noisy and did not add value

If the goal here is to prevent fluctuations what I would prefer to see is for you to work on your fork of Anki-Android, with codecov enabled there, and actually determine why there are fluctuations then propose a PR to fix the fluctuations

Simply turning on annotations here adds a lot of noise to all PRs and does not solve the issue

(note: you will most likely need to go to codecov with your github login and enable coverage uploading without a token... as was shown in comments for #17443 / #17443 (comment) )

@BrayanDSO BrayanDSO marked this pull request as draft December 19, 2024 11:29
@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Author Reply Waiting for a reply from the original author New contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants