Skip to content

Commit

Permalink
Added code to detect micro architecture
Browse files Browse the repository at this point in the history 
- zlinux version detection
- add tests

resolves: adoptium#471
Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
  • Loading branch information
@annaibm
annaibm committed Apr 2, 2024
1 parent 1a72ab8 commit c869c00
Show file tree
Hide file tree
Showing 5 changed files with 255 additions and 109 deletions.
71 changes: 70 additions & 1 deletion examples/platformRequirements/playlist.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,74 @@
$(TEST_STATUS)</command>
<platformRequirements>^os.linux.ubuntu.20+</platformRequirements>
</test>
<test>
<testCaseName>test_not_microarch_supported</testCaseName>
<command>echo "test on none microarch.supported"; \
$(TEST_STATUS)</command>
<platformRequirements>^microarch.supported</platformRequirements>
</test>
<!-- Test for skylake microarchitecture -->
<test>
<testCaseName>test_microarch_skylake</testCaseName>
<command>echo "test microarch.skylake"; \
$(TEST_STATUS)</command>
<platformRequirementsList>
<platformRequirements>microarch.skylake</platformRequirements>
</platformRequirementsList>
</test>
<!-- Test for z15+ microarchitecture -->
<test>
<testCaseName>test_microarch_z15plus</testCaseName>
<command>echo "test microarch.z15+";
$(TEST_STATUS)</command>
<platformRequirementsList>
<platformRequirements>microarch.z15+</platformRequirements>
</platformRequirementsList>
</test>
<!-- Test for z15 microarchitecture -->
<test>
<testCaseName>test_microarch_z15</testCaseName>
<command>echo "test microarch.z15"; \
$(TEST_STATUS)</command>
<platformRequirementsList>
<platformRequirements>microarch.z15</platformRequirements>
</platformRequirementsList>
</test>
<!-- Test for z14+ microarchitecture -->
<test>
<testCaseName>test_microarch_z14plus</testCaseName>
<command>echo "test microarch.z14+"; \
$(TEST_STATUS)</command>
<platformRequirementsList>
<platformRequirements>microarch.z14+</platformRequirements>
</platformRequirementsList>
</test>
<!-- Test for z14 microarchitecture -->
<test>
<testCaseName>test_microarch_z14</testCaseName>
<command>echo "test microarch.z14"; \
$(TEST_STATUS)</command>
<platformRequirementsList>
<platformRequirements>microarch.z14</platformRequirements>
</platformRequirementsList>
</test>
<!-- Test for z13+ microarchitecture -->
<test>
<testCaseName>test_microarch_z13plus</testCaseName>
<command>echo "test microarch.z13+"; \
$(TEST_STATUS)</command>
<platformRequirementsList>
<platformRequirements>microarch.z13+</platformRequirements>
</platformRequirementsList>
</test>
<!-- Test for z13 microarchitecture -->
<test>
<testCaseName>test_microarch_z13</testCaseName>
<command>echo "test microarch.z13"; \
$(TEST_STATUS)</command>
<platformRequirementsList>
<platformRequirements>microarch.z13</platformRequirements>
</platformRequirementsList>
</test>

</playlist>
</playlist>
2 changes: 1 addition & 1 deletion makeGen.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ autoconfig:
perl scripts$(D)configure.pl

autogen: autoconfig
${TEST_JDK_HOME}/bin/java -cp $(Q)$(TKG_JAR)$(P)$(JSON_SIMPLE)$(Q) org.testKitGen.MainRunner --mode=$(MODE) --spec=$(SPEC) --microArch=$(MICROARCH) --osLabel=$(Q)$(OS_LABEL)$(Q) --jdkVersion=$(JDK_VERSION) --impl=$(JDK_IMPL) --vendor=$(Q)$(JDK_VENDOR)$(Q) --buildList=${BUILD_LIST} --iterations=$(TKG_ITERATIONS) --aotIterations=$(AOT_ITERATIONS) --testFlag=$(TEST_FLAG) --testTarget=$(TESTTARGET) --testList=$(TESTLIST) --numOfMachines=$(NUM_MACHINES) --testTime=$(TEST_TIME) --TRSSURL=$(TRSS_URL) $(OPTS)
${TEST_JDK_HOME}/bin/java -cp $(Q)$(TKG_JAR)$(P)$(JSON_SIMPLE)$(Q) org.testKitGen.MainRunner --mode=$(MODE) --spec=$(SPEC) --microArch=$(Q)$(MICROARCH)$(Q) --osLabel=$(Q)$(OS_LABEL)$(Q) --jdkVersion=$(JDK_VERSION) --impl=$(JDK_IMPL) --vendor=$(Q)$(JDK_VENDOR)$(Q) --buildList=${BUILD_LIST} --iterations=$(TKG_ITERATIONS) --aotIterations=$(AOT_ITERATIONS) --testFlag=$(TEST_FLAG) --testTarget=$(TESTTARGET) --testList=$(TESTLIST) --numOfMachines=$(NUM_MACHINES) --testTime=$(TEST_TIME) --TRSSURL=$(TRSS_URL) $(OPTS)

AUTOGEN_FILES = $(wildcard $(CURRENT_DIR)$(D)jvmTest.mk)
AUTOGEN_FILES += $(wildcard $(CURRENT_DIR)$(D)machineConfigure.mk)
Expand Down
255 changes: 155 additions & 100 deletions scripts/testTKG/test_platformRequirements.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,105 +16,160 @@
from utils import *

def run_test():
rt = True
printTestheader("platformRequirements")

buildList = "TKG/examples/platformRequirements"
command = "make _all"
print(f"\t{command}")
result = subprocess.run(f"{EXPORT_BUILDLIST}={buildList}; {CD_TKG}; {MAKE_CLEAN}; {MAKE_COMPILE}; {command}", stderr=subprocess.PIPE, stdout=subprocess.PIPE, shell=True, check=False)

stdout = result.stdout.decode()
specStr = re.search(r"set SPEC to (.*)", stdout)

if specStr is not None:
spec = specStr.group(1)
else:
printError("Could not parse spec from output.")
return False

passed = set()
skipped = set()

if 'linux' in spec:
skipped.add('test_not_linux_arch_x86_0')
else:
if 'x86' in spec:
passed.add('test_not_linux_arch_x86_0')
else:
skipped.add('test_not_linux_arch_x86_0')

if 'x86' in spec:
passed.add('test_arch_x86_0')
skipped.add('test_arch_nonx86_0')
else:
passed.add('test_arch_nonx86_0')
skipped.add('test_arch_x86_0')

if '64' in spec:
passed.add('test_bits_64_0')
else:
skipped.add('test_bits_64_0')

if 'osx' in spec:
passed.add('test_os_osx_0')
else:
skipped.add('test_os_osx_0')

if 'osx_x86-64' in spec:
passed.add('test_osx_x86-64_0')
else:
skipped.add('test_osx_x86-64_0')

if 'x86' in spec or '390' in spec:
passed.add('test_arch_x86_390_0')
else:
skipped.add('test_arch_x86_390_0')

if 'osx_x86-64' in spec or ('win_x86' in spec and 'win_x86-64' not in spec) or 'aix_ppc-64' in spec:
passed.add('test_osx_x86-64_win_x86_aix_ppc-64_0')
else:
skipped.add('test_osx_x86-64_win_x86_aix_ppc-64_0')

os_label = re.search(r"set OS_LABEL to (.*)", stdout)
if os_label is not None:
os_label = os_label.group(1)
label_str = os_label.split(".")
# os_label example: ubuntu.22
try:
ver = int(label_str[1],10)
if label_str[0] == "ubuntu":
if ver >= 22:
passed.add('test_os_linux_ubuntu22_0')
if ver >= 20:
passed.add('test_os_linux_ubuntu20plus_0')
passed.add('test_os_linux_ubuntu20plus_rhel8plus_0')
if ver < 20:
passed.add('test_not_os_linux_ubuntu20plus_0')

if label_str[0] == "rhel":
if ver >= 8:
passed.add('test_os_linux_ubuntu20plus_rhel8plus_0')
except ValueError as ve:
print ("warning: os version value failed to convert to an integer")
passed.add('test_not_os_linux_ubuntu20plus_0')
else:
passed.add('test_not_os_linux_ubuntu20plus_0')

if 'test_os_linux_ubuntu20plus_0' not in passed:
skipped.add('test_os_linux_ubuntu20plus_0')

if 'test_os_linux_ubuntu22_0' not in passed:
skipped.add('test_os_linux_ubuntu22_0')

if 'test_os_linux_ubuntu20plus_rhel8plus_0' not in passed:
skipped.add('test_os_linux_ubuntu20plus_rhel8plus_0')

if 'test_not_os_linux_ubuntu20plus_0' not in passed:
skipped.add('test_not_os_linux_ubuntu20plus_0')

rt &= checkResult(result, passed, set(), set(), skipped)
return rt
rt = True
printTestheader("platformRequirements")

buildList = "TKG/examples/platformRequirements"
command = "make _all"
print(f"\t{command}")
result = subprocess.run(f"{EXPORT_BUILDLIST}={buildList}; {CD_TKG}; {MAKE_CLEAN}; {MAKE_COMPILE}; {command}", stderr=subprocess.PIPE, stdout=subprocess.PIPE, shell=True, check=False)

stdout = result.stdout.decode()
specStr = re.search(r"set SPEC to (.*)", stdout)

if specStr is not None:
spec = specStr.group(1)
else:
printError("Could not parse spec from output.")
return False

passed = set()
skipped = set()

if 'linux' in spec:
skipped.add('test_not_linux_arch_x86_0')
else:
if 'x86' in spec:
passed.add('test_not_linux_arch_x86_0')
else:
skipped.add('test_not_linux_arch_x86_0')

if 'x86' in spec:
passed.add('test_arch_x86_0')
skipped.add('test_arch_nonx86_0')
else:
passed.add('test_arch_nonx86_0')
skipped.add('test_arch_x86_0')

if '64' in spec:
passed.add('test_bits_64_0')
else:
skipped.add('test_bits_64_0')

if 'osx' in spec:
passed.add('test_os_osx_0')
else:
skipped.add('test_os_osx_0')

if 'osx_x86-64' in spec:
passed.add('test_osx_x86-64_0')
else:
skipped.add('test_osx_x86-64_0')

if 'x86' in spec or '390' in spec:
passed.add('test_arch_x86_390_0')
else:
skipped.add('test_arch_x86_390_0')

if 'osx_x86-64' in spec or ('win_x86' in spec and 'win_x86-64' not in spec) or 'aix_ppc-64' in spec:
passed.add('test_osx_x86-64_win_x86_aix_ppc-64_0')
else:
skipped.add('test_osx_x86-64_win_x86_aix_ppc-64_0')

os_label = re.search(r"set OS_LABEL to (.*)", stdout)
print("os_label in : {}".format(os_label))
if os_label is not None:
os_label = os_label.group(1)
label_str = os_label.split(".")
# os_label example: ubuntu.22
try:
ver = int(label_str[1],10)
if label_str[0] == "ubuntu":
if ver >= 22:
passed.add('test_os_linux_ubuntu22_0')
if ver >= 20:
passed.add('test_os_linux_ubuntu20plus_0')
passed.add('test_os_linux_ubuntu20plus_rhel8plus_0')
if ver < 20:
passed.add('test_not_os_linux_ubuntu20plus_0')

if label_str[0] == "rhel":
if ver >= 8:
passed.add('test_os_linux_ubuntu20plus_rhel8plus_0')
except ValueError as ve:
print ("warning: os version value failed to convert to an integer")
passed.add('test_not_os_linux_ubuntu20plus_0')
else:
passed.add('test_not_os_linux_ubuntu20plus_0')

if 'test_os_linux_ubuntu20plus_0' not in passed:
skipped.add('test_os_linux_ubuntu20plus_0')

if 'test_os_linux_ubuntu22_0' not in passed:
skipped.add('test_os_linux_ubuntu22_0')

if 'test_os_linux_ubuntu20plus_rhel8plus_0' not in passed:
skipped.add('test_os_linux_ubuntu20plus_rhel8plus_0')

if 'test_not_os_linux_ubuntu20plus_0' not in passed:
skipped.add('test_not_os_linux_ubuntu20plus_0')

micro_arch = re.search(r"set MICROARCH to (.*)", stdout)
print("micro_arch in platform req: {}".format(micro_arch))
if micro_arch is not None:
micro_arch = micro_arch.group(1)
label_str = micro_arch
print("Label_str:",label_str)
# micro_arch example: skylake
try:
ver = int(''.join(filter(str.isdigit, micro_arch.split()[-1])))
print("ver:",ver)
if label_str == "skylake":
passed.add('test_microarch_skylake_0')
if ver == 13:
passed.add('test_microarch_z13_0')
elif ver > 13:
passed.add('test_microarch_z13plus_0')
if ver == 14:
passed.add('test_microarch_z14_0')
elif ver > 14:
passed.add('test_microarch_z14plus_0')
if ver == 15:
passed.add('test_microarch_z15_0')
elif ver > 15:
passed.add('test_microarch_z15plus_0')
else:
skipped.add('test_not_microarch_supported_0')
except ValueError as ve:
print("warning: microarch version value failed to convert to an integer")
skipped.add('test_not_microarch_supported_0')
else:
passed.add('test_not_microarch_supported_0')

if 'test_microarch_z15_0' not in passed:
skipped.add('test_microarch_z15_0')

if 'test_microarch_z14_0' not in passed:
skipped.add('test_microarch_z14_0')

if 'test_microarch_z13_0' not in passed:
skipped.add('test_microarch_z13_0')

if 'test_microarch_z15plus_0' not in passed:
skipped.add('test_microarch_z15plus_0')

if 'test_microarch_z14plus_0' not in passed:
skipped.add('test_microarch_z14plus_0')

if 'test_microarch_z13plus_0' not in passed:
skipped.add('test_microarch_z13plus_0')

if 'test_microarch_skylake_0' not in passed:
skipped.add('test_microarch_skylake_0')


rt &= checkResult(result, passed, set(), set(), skipped)
return rt

if __name__ == "__main__":
run_test()
run_test()
8 changes: 4 additions & 4 deletions settings.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ ifndef JVM_VERSION

ifeq (hotspot, $(JDK_IMPL))
JVM_VERSION = $(OPENJDK_VERSION)
else
else
JVM_VERSION = $(OPENJDK_VERSION)-$(JDK_IMPL)
endif

Expand All @@ -103,7 +103,7 @@ ifneq (,$(findstring win,$(SPEC)))
P=;
D=\\
EXECUTABLE_SUFFIX=.exe
RUN_SCRIPT="cmd /c"
RUN_SCRIPT="cmd /c"
RUN_SCRIPT_STRING=$(RUN_SCRIPT)
SCRIPT_SUFFIX=.bat
PROPS_DIR=props_win
Expand Down Expand Up @@ -380,8 +380,8 @@ setup_%: testEnvSetup
@$(ECHO) set JAVA_HOME to $(JAVA_HOME)
@$(ECHO) set SPEC to $(SPEC)
@$(ECHO) set TEST_FLAG to $(TEST_FLAG)
@if [ $(MICROARCH) ]; then \
$(ECHO) set MICROARCH to $(MICROARCH); \
@if [ "$(MICROARCH)" ]; then \
$(ECHO) set MICROARCH to "$(MICROARCH)"; \
fi
@if [ $(OS_LABEL) ]; then \
$(ECHO) set OS_LABEL to $(OS_LABEL); \
Expand Down
Loading

0 comments on commit c869c00

Please sign in to comment.