Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix room m.mention when firing #129

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

HarHarLinks
Copy link
Collaborator

@HarHarLinks HarHarLinks commented Jan 6, 2024

previously behavior of

mentions_user_ids=[self.target_user] if self.has_target() else [],
mentions_room=self.has_target(),

did not match
mentions_room=not self.has_target(),
mentions_user_ids=[self.target_user] if self.has_target() else None,

@HarHarLinks HarHarLinks merged commit 379d281 into master Jan 6, 2024
10 checks passed
@HarHarLinks HarHarLinks added the bug Something isn't working label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant