Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS shortcuts #144

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Add iOS shortcuts #144

merged 2 commits into from
Aug 14, 2024

Conversation

th0mcat
Copy link
Contributor

@th0mcat th0mcat commented Feb 7, 2024

I created a couple iOS shortcuts that allow you to send unencrypted reminder requests directly to a room that contains a reminder bot instance. One is for normal requests, one is for cron requests. A small time saver for those with large room lists.

@HarHarLinks HarHarLinks added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 7, 2024
Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your contribution. I could test the shortcut for the regular reminder successfully, and I do think the idea is generally neat and absolutely matches my spirit of hacking matrix tools together!

Unfortunately the intended cron shortcut does not appear to be correct? Executing it matches what I expected from reading the code; my room received !c<time>; <message>.

Note that the syntax for setting cron reminders is !remindme|remind|r cron <min> <hour> <day of month> <month> <day of week>; <reminder text>, i.e. !r cron <time>; <message>. So the command needs to change slightly from the !c command (which is short for !cancelreminder) and add a space before the definition.

While I still like the idea, I wonder if we need to consider security carefully here, since we are saving an access token in plain text. On the other hand, the Matrix client like to be already running on the device already has a token, too, and exposes it to the user on demand (though I can't find how it is possible using both Element legacy and X). Probably we should at least add a small warning about handling tokens responsibly?

@th0mcat
Copy link
Contributor Author

th0mcat commented Feb 8, 2024

🤦 That’s what I get for not testing the cron shortcut while lacking sleep.

I think a warning is a great idea, would you prefer the shortcut itself to have a warning, a warning in the README, or both?

@HarHarLinks
Copy link
Collaborator

HarHarLinks commented Feb 8, 2024

I thought of the README as I wrote this, but maybe you can also find a good way to remind users of this fact as they "install" the shortcut?

@th0mcat
Copy link
Contributor Author

th0mcat commented Feb 15, 2024

Alright, updated the README as well as the shortcuts to include warnings.

@HarHarLinks HarHarLinks mentioned this pull request Feb 19, 2024
4 tasks
@HarHarLinks HarHarLinks merged commit eecc974 into anoadragon453:master Aug 14, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants