check sender and bot PL before accepting room reminder #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarHarLinks
commented
Feb 17, 2024
| bot_pl = self.room.power_levels.users.get(self.client.user_id, 0) | ||
| if sender_pl < room_ping_pl: | ||
| insufficient = f"You (<code>{sender_pl}</code>) do" | ||
| elif bot_pl < room_ping_pl: |
There was a problem hiding this comment.
the use case of #80 is not possible to partially work around with PLs anymore, so it now needs to get addressed more than ever.
HarHarLinks
commented
Feb 17, 2024
Comment on lines
+351
to
+353
| text = f"Insufficient rights: {insufficient} not have the required power level to ping the whole room (<code>{room_ping_pl}</code>)." | ||
| await send_text_to_room(self.client, self.room.room_id, text) | ||
| return True |
There was a problem hiding this comment.
Suggested change
| text = f"Insufficient rights: {insufficient} not have the required power level to ping the whole room (<code>{room_ping_pl}</code>)." | |
| await send_text_to_room(self.client, self.room.room_id, text) | |
| return True | |
| raise CommandError(f"Insufficient rights: {insufficient} not have the required power level to ping the whole room (<code>{room_ping_pl}</code>).") |
Comment on lines
+357
to
+358
| if await self._insufficient_room_ping_pl(): | ||
| return |
There was a problem hiding this comment.
Suggested change
| if await self._insufficient_room_ping_pl(): | |
| return | |
| self._insufficient_room_ping_pl() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #137
outstanding: #80, #158