replace pretty_cron with cron_descriptor #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably resolves #73 - assuming this library never has to fall back to cron syntax as the old one did.Narrator: It didn't.
My example there was
0 11,20 * * *which the new lib words as "'At 11:00 and 20:00". I chose the 24hour format specifically to match the crontab better, but feel free to ignore that commit.On a side note, this lib supports a couple localized output formats, if the bot is ever going to support that.
Perhaps it should still check for and escape
*which are not in code blocks.