fix: handling errors in a better way (#1354)

anoma · Dec 2, 2024 · 4e26466 · 4e26466 · github-actions · Dec 2, 2024
1 parent 231d0a0
commit 4e26466
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/apps/namadillo/src/App/Common/InlineError.tsx b/apps/namadillo/src/App/Common/InlineError.tsx
@@ -1,6 +1,5 @@
 import clsx from "clsx";
 import React from "react";
-import { GoXCircle } from "react-icons/go";
 
 type InlineErrorProps = {
   errorMessage?: React.ReactNode;
@@ -13,10 +12,10 @@ export const InlineError = ({
   return (
     <div
       className={clsx(
-        "text-fail text-sm flex items-center gap-1.5 selection:bg-fail selection:text-black"
+        "text-fail text-sm items-center gap-1.5 selection:bg-fail selection:text-black",
+        "break-words"
       )}
     >
-      <GoXCircle />
       {errorMessage}
     </div>
   );

diff --git a/apps/namadillo/src/atoms/integrations/services.ts b/apps/namadillo/src/atoms/integrations/services.ts
@@ -5,6 +5,7 @@ import {
   DeliverTxResponse,
   SigningStargateClient,
   StargateClient,
+  assertIsDeliverTxSuccess,
 } from "@cosmjs/stargate";
 import { TransactionFee } from "App/Transfer/TransferModule";
 import { queryForAck, queryForIbcTimeout } from "atoms/transactions";
@@ -134,10 +135,7 @@ export const submitIbcTransfer = async (
     fee
   );
 
-  if (response.code !== 0) {
-    throw new Error(response.code + " " + response.transactionHash);
-  }
-
+  assertIsDeliverTxSuccess(response);
   return response;
 };