-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/944 - Extension updates - BIP44/Zip32/Ledger/Masp #1155
Conversation
2b79d14
to
aa2ae09
Compare
152419a
to
2fe95ce
Compare
0306c9b
to
8331e5c
Compare
c6fe8fa
to
6b33660
Compare
d37cf04
to
c049a7a
Compare
961813f
to
46b7444
Compare
const path = { | ||
account: accountDetails.path.account, | ||
change: accountDetails.path.change || 0, | ||
index: accountDetails.path.index || 0, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For signing with transparent keys, all of these values are expected to be present! Ledger does not have Zip32 paths as of yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great!
I have couple of minor UI/UX comments.
I personally do not like these numeric input arrows :D
Also maybe we can reduce font size or sth so we do not see the scroll.
I'm curious if it makes sense to enable "advanced" button only if we are in Step 2 of HW Wallet import flow. Not sure xd
Thanks! Yeah some of these style things I will fix in a follow-up PR before release, I think those are all good suggestions! |
b8644d9
to
4541032
Compare
FYI: Tracking these comments in #1229 ! |
4541032
to
05a349c
Compare
Resolves #944
Resolves #1154
sdk.keys.deriveShieldedFromSeed()
sdk.keys.deriveShieldedFromPrivateKey()
makeSaplingPathArray(path)
)TODO
makeSaplingPathArray(path)
)Import
->Private Key
using a default pathsdk
ortypes
changes! NOTE This should be in a separate, SDK-release PR, as other PRs will affect the docs too and it creates too much noise for an already large PRScreenshots
NOTE Styles are still in progress...
Advanced Menu (Import Mnemonic):
Custom Derivation Path:
Bip39 Passphrase:
Keychain & SDK versions:
SDK version in Namadillo:
Path displayed (only when a custom path was specified):
Designs
Updated designs for
Viewing Key
:FIGMA:
https://www.figma.com/design/NFyHbLZXBSl3aUsMxtffvV/Namada-End-User-Interface-V1.0-%2F-Phase-1%3A-Block-Party?node-id=6361-75215&node-type=canvas&t=cJGwuzI3Q8soSDus-0