feat: support decoding ibc tx details in sdk #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emccorson
commented
Oct 11, 2024
emccorson
commented
jurevans
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
This looks good! I think (if you like) this could go ahead and go in. I think we can chat more about how to handle the timeout_sec_offset & shielding_data then one of us can follow up in another PR, but we're pretty well covered for transparent IBC with this!
emccorson
force-pushed
the
ibc-extension-details
branch
from
7b49b5e
to
5c98cd2
Compare
|
I will go ahead and merge this as suggested, and I've created an issue #1196 to follow up. |
emccorson
force-pushed
the
ibc-extension-details
branch
from
5c98cd2
to
1bd083b
Compare
mateuszjasiuk
pushed a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.