Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fully decode IBC assets on cosmos chains #1216

Closed
wants to merge 0 commits into from

Conversation

emccorson
Copy link
Collaborator

@emccorson emccorson commented Oct 29, 2024

If there are IBC assets on a Keplr account, attempt to look them up on the chain they came from and display them. For example, if there are NAM tokens on a Cosmos Hub account, display them as NAM.

Notes:

Testing

  1. Configure Namadillo to use the internal devnet
  2. Go to IBC Transfer -> From Namada and send some NAM to your Cosmos Hub testnet account (assuming Namadillo IBC features are enabled and Keplr is set up)
  3. Go to IBC Transfer -> To Namada and select the Cosmos Hub testnet
  4. In the asset list, you should see the tokens you sent listed as "Namada" and the denomination treated as NAM (e.g. if you have 1 NAM, it shows the balance as 1, not 1000000)

You can also try sending other IBC tokens (e.g. send some OSMO from Osmosis testnet to Cosmos Hub testnet) and it should also display properly.

Copy link
Contributor

@pedrorezende pedrorezende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would just review carefully the import I mentioned in one of the comments

apps/namadillo/src/atoms/integrations/functions.ts Outdated Show resolved Hide resolved
apps/namadillo/src/atoms/integrations/services.ts Outdated Show resolved Hide resolved
emccorson added a commit that referenced this pull request Oct 31, 2024
If there are IBC assets on a Keplr account, attempt to look them up on
the chain they came from and display them. For example, if there are NAM
tokens on a Cosmos Hub account, display them as NAM.
@emccorson emccorson closed this Oct 31, 2024
@emccorson
Copy link
Collaborator Author

This is merged (I just messed up getting GitHub to realise that, so it think it's closed).

@github-actions github-actions bot temporarily deployed to production October 31, 2024 03:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants