Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decode IBC assets sent over multiple channels #1228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emccorson
Copy link
Collaborator

@emccorson emccorson commented Nov 1, 2024

This PR adds support for displaying asset information for IBC assets that have been sent over multiple channels (e.g. Namada -> Cosmos Hub -> Osmosis).

Closes #1219.

Testing

I found it a bit difficult to find live relayers for testing this, but I did get it to work with Namada devnet -> Cosmoshub testnet -> Elys testnet.

  1. Transfer some NAM from the internal devnet to Cosmoshub testnet using Namadillo
  2. Select "Elys Network" in Namadillo to prompt it to be added to Keplr
  3. Transfer the NAM from Cosmoshub testnet to Elys testnet using gaiad (Keplr might work too but I've never tried)
  4. Refresh Namadillo and select "Elys Network"
  5. Your NAM should appear in the asset list with Namada icon and proper denomination handling.

You can also test by sending other assets between multiple chains if there are live relayers.


Added

  • Decode IBC assets sent over multiple channels
  • Add elystestnet temporarily for testing

Fixed

  • Fix missing icon for Namada on IBC transfer page.

Also fix missing icon for Namada on IBC transfer page.

Closes #1219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namadillo: IBC -> Check if we can decode IBC assets transferred between more than two chains
1 participant