Namadillo: Top Navigation improvements #1475
Conversation
|
|
||
| {unshieldingModalOpen && ( | ||
| <UnshieldAssetsModal onClose={() => setUnshieldingModalOpen(false)} /> | ||
| )} |
There was a problem hiding this comment.
We could use the same navigation structure of backgroundLocation because we have other Shield buttons, then it'll be easier to reuse this implementation :)
There was a problem hiding this comment.
I tried to keep it simple for now, do we have any other place that we have such a generic "shield" button that would justify moving this piece to a route?
There was a problem hiding this comment.
The yellow banner on the sidebar
There was a problem hiding this comment.
I remember that it will be removed and re-added when we have the "Shield All" functionality
There was a problem hiding this comment.
Oh, you are right, thanks for reminding it!
We also have this banner on Transparent Overview. But we need to check with @ChrisHoltDesign if we need to update this action as well
There was a problem hiding this comment.
So that 'shield button' in the transparent assets section should ideally load the 'Internal shield option', not the IBC version.
As it's an action to shield assets that are in your Namada transparent account
There was a problem hiding this comment.
Thanks Chris!
So we are good having this modal only on top navigation :)
|
@pedrorezende @euharrison This button should also open up the modal 
Lets change the text to 'shield assets' also |
Closes #1409