Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transfer balance warning #1488

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

euharrison
Copy link
Collaborator

Add transfer balance warning in case there are some balance but it's below the fee

This is important so user don't think Namadillo has a bug not fetching the balance

Screenshot 2025-01-08 at 16 26 50

Copy link
Collaborator

@pedrorezende pedrorezende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! But I was talking to @ChrisHoltDesign about displaying this validation message in the button text. For me it's approved in terms of code, but I'll let him take a look on that first before raising the green flag :)

@euharrison
Copy link
Collaborator Author

euharrison commented Jan 10, 2025

@pedrorezende he gave the green flag :)
https://heliax.slack.com/archives/C03JY8E9571/p1736369220041339?thread_ts=1736358547.515179&cid=C03JY8E9571

The button will preserve the same current flow

In case the user don't fill the amount it shows "Define an amount to transfer"
Screenshot 2025-01-10 at 11 23 18

And in case it fills any amount, it shows "Not enough balance"
Screenshot 2025-01-10 at 11 23 11

@euharrison euharrison merged commit 2b7348e into main Jan 10, 2025
10 checks passed
@euharrison euharrison deleted the feat/transfer-balance-warning branch January 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants