Various bug fixes #199
Merged
Various bug fixes #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three leaks would occur in erroneous function paths.
The data should be loaded into the local variable `mydata`, not into the NULL parameter.
First check whether we are past the array, only then read and check its values.
TheTumultuousUnicornOfDarkness
approved these changes
May 26, 2024
TheTumultuousUnicornOfDarkness
merged commit 381b335
into
anrieff:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various issues found by static analysis tools. The most serious issue is in
cpuid_get_hypervisor, which leads to segmentation faults when the caller passes a NULL parameter, even though the documentation claims that it is safe.