Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAPS security profile ansible support #414

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

aravindmani-1
Copy link
Contributor

SUMMARY

Added the changes required for LDAP security profile

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
ISSUE TYPE
COMPONENT NAME

sonic_ldap

OUTPUT

ldaps_security_profile regression report.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@aravindmani-1 aravindmani-1 marked this pull request as ready for review September 2, 2024 15:59
@kerry-meyer kerry-meyer added this to the v3.1.0 milestone Oct 25, 2024
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed functional code changes and regression test results look good. I am requesting a couple of changes to this PR to improve UT test coverage and to post the full output for the regression test results:

  • Please add UT coverage for the new option. (No new test cases are needed, but please make the needed changes in the "tests/unit/modules/network/sonic/fixtures/sonic_ldap.yaml" file.)
  • Also, please attach a new version of the regression results that doesn't chop off the rightmost columns. This can be done by printing to a file in "landscape" (instead of "portrait") mode and scaling the output as needed so it fits.

@aravindmani-1
Copy link
Contributor Author

The proposed functional code changes and regression test results look good. I am requesting a couple of changes to this PR to improve UT test coverage and to post the full output for the regression test results:

  • Please add UT coverage for the new option. (No new test cases are needed, but please make the needed changes in the "tests/unit/modules/network/sonic/fixtures/sonic_ldap.yaml" file.)
  • Also, please attach a new version of the regression results that doesn't chop off the rightmost columns. This can be done by printing to a file in "landscape" (instead of "portrait") mode and scaling the output as needed so it fits.

New regression report:
regression-2024-11-11-21-25-00.pdf

UT:
codecoverage ldap.txt

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest updates, all proposed code changes, including new test cases, and all corresponding test results look good.

Thank you for providing this enhancement to the functionality of the sonic_ldap resource module.

Approved.

@kerry-meyer kerry-meyer merged commit 2732b21 into ansible-collections:main Nov 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants