Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp_communities - Update 'aann' option, Fix issues in merged state #440

Conversation

ArunSaravananBalachandran
Copy link
Collaborator

@ArunSaravananBalachandran ArunSaravananBalachandran commented Aug 22, 2024

SUMMARY

Incorporate the below changes in sonic_bgp_communites module:

  • Change 'aann' as a suboption of 'members' and update it to support 'list of strings'.
  • Fix issue in merged state for standard community-list when community options are specified as 'False'.
  • Update default value behavior for 'type' and 'match' to be in-line with 'permit'.
  • Update documentation, UT and regression test cases.
  • Resolve ansible-lint reported failures.
GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • sonic_bgp_communities
OUTPUT
ADDITIONAL INFORMATION
Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Regression report: bgp_communities_regression_report-2024-09-26-11-18-07.pdf

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing these changes to provide more complete support in the enterprise_sonic Ansible resource module collection for the BGP Communities functionality currently implemented in SONiC.

The proposed changes, updated test cases, and test results look good.

I am posting only a few minor comments/questions.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the posted comments.

All current proposed code changes and comments, test cases, and test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 6eafbcd into ansible-collections:main Sep 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants