-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new unreliable_los option #453
Add new unreliable_los option #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing this new functionality.
I am posting a few minor comments to address before merging of this PR.
plugins/module_utils/network/sonic/argspec/interfaces/interfaces.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost all of the pending "Issues" are "Resolved" by your most recent set of changes.
I have one remaining "Issue" related to setting up the required conditions for integration test_06.
Everything else looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the final requested change.
All proposed code changes, added test cases, and test results look good.
Approved.
SUMMARY
Set interface configuration option for when to generate a 'loss of service' (LOS) alarm
GitHub Issues
"N/A"
ISSUE TYPE
COMPONENT NAME
sonic_interfaces
OUTPUT
Ansible Report:
add_unreliable_los.pdf
Raw Regression Test Output:
unreliable_los.zip
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration