Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VRRP regression failures #455

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

santhosh-kt
Copy link
Collaborator

@santhosh-kt santhosh-kt commented Sep 25, 2024

SUMMARY
  • Update DELETE handling to fix VRRP regression failure.
  • Update "update_url" to handle multiple interface names in request path
  • Fix ansible-lint failures in sonic_vrrp.
GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • sonic_vrrp
OUTPUT

ADDITIONAL INFORMATION

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

regression-2024-09-25-16-24-44.zip

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick action in providing these fixes.

The proposed code changes, added test coverage, and integration+UT results all look good.

Please resync your fork and branch to pick up the fix merged today for the Ansible version 2.19 sanity failures (milestone and devel) so we can merge this PR with all tests passing.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All proposed changes in this change set, additional tests, and corresponding test results look good.

Thank you for your quick action in fixing these problems (and the URL encode handling problem).

Approved.

@kerry-meyer kerry-meyer merged commit 3aa8ae5 into ansible-collections:main Sep 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants