Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cable_length attribute to QoS interfaces module #468

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Add cable_length attribute to QoS interfaces module #468

wants to merge 22 commits into from

Conversation

ohu1
Copy link
Contributor

@ohu1 ohu1 commented Oct 11, 2024 •
edited
Loading

SUMMARY

Add 'cable_length' attribute to QoS interfaces module

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_qos_interfaces

ADDITIONAL INFORMATION
Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Regression test with updated testcases.

[
regression-2024-11-08-cable-length.txt.gz
](url)

@ohu1 ohu1 changed the title WIP: cable length support cable length support Oct 21, 2024
@stalabi1 stalabi1 changed the title cable length support Add cable_length attribute to QoS interfaces module Oct 21, 2024
@stalabi1 stalabi1 added the enhancement New feature or request label Oct 21, 2024
@stalabi1 stalabi1 added this to the v3.1.0 milestone Oct 21, 2024
ohu1 and others added 5 commits October 23, 2024 16:35
@ohu1 @stalabi1
Update changelogs/fragments/468-cable-length.yaml
fe33d2e 
Co-authored-by: stalabi1 <54641848+stalabi1@users.noreply.github.com>
@ohu1 @stalabi1
Update plugins/modules/sonic_qos_interfaces.py
cdc5dcb 
Co-authored-by: stalabi1 <54641848+stalabi1@users.noreply.github.com>
@ohu1 @stalabi1
Update plugins/module_utils/network/sonic/argspec/qos_interfaces/qos_…
5a8896a 
…interfaces.py

Co-authored-by: stalabi1 <54641848+stalabi1@users.noreply.github.com>
@ohu1 @stalabi1
Update plugins/modules/sonic_qos_interfaces.py
a0c8c48 
Co-authored-by: stalabi1 <54641848+stalabi1@users.noreply.github.com>
@ohu1 @stalabi1
Update plugins/modules/sonic_qos_interfaces.py
a2f685c 
Co-authored-by: stalabi1 <54641848+stalabi1@users.noreply.github.com>
@ohu1 ohu1 requested a review from stalabi1 October 24, 2024 17:34
@ohu1 ohu1 closed this Nov 8, 2024
@ohu1 ohu1 reopened this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalabi1 stalabi1 stalabi1 approved these changes

@kerry-meyer kerry-meyer Awaiting requested review from kerry-meyer kerry-meyer is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ohu1 @stalabi1