Fix functionality to allow a value of 0 to be configured for the appropriate integer attributes and refactor STP module code

[stalabi1]

SUMMARY

• I fixed the functionality of the code to allow a value of 0 to be configured for the appropriate integer attributes.
• I removed all of the default definitions from the argspec because the definitions were making some configuration cases impossible to implement, e.g. the deletion of an STP interface by interface name that has all defaults configured.
• I refactored the code to reduce the number of nested loops in the case of searching for instance matches. I condensed a few of the get delete request methods.
• I added more UT test cases to increase code coverage.
• I updated the facts code to properly handle empties allowing me to remove a few 'remove_empties' calls from config.

GitHub Issues

GitHub Issue #472

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

sonic_stp

OUTPUT

regression-2024-11-11-14-59-56.html.pdf
merge_mst_id_0_output.log

ADDITIONAL INFORMATION

Current SONiC behavior doesn't allow me to to configure any other mst-id when mst-id 0 is configured.

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
• I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

[TafkaMax]

Tested this branch and it fixes the issue I had.

[kerry-meyer]

This change set, the additional test cases, and the corresponding test results looks good.

Thanks for adding efficiency improvements and reductions in the existing code along with the basic fix.

I am posting several minor comments/questions and change requests, but am not requesting any significant algorithmic changes.

[kerry-meyer]

All current proposed changes and corresponding test results look good.

Thank you for not only fixing the problem described by the customer, but for taking the initiative to fix all related exposures in the STP resource module.

Approved.