-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alma 8 GPG Key #369
Conversation
Update AlmaLinux.yml Signed-off-by: ajython <ajython@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct inline with https://almalinux.org/blog/2023-12-20-almalinux-8-key-update/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant and explanation link included
Hi Thank you for taking the time to raise this PR, really appreciate the fact the url is also added to show the reasoning behind this.
The link that you provided really helped to point us in the correct direction. If you want to change the value and add to README, happy to accept the PR or i am able to bring this into another PR i'm currently working on. Many thanks uk-bolly p.s. Also thinking a pre-check maybe a good idea to ensure the version of the release package is 8.8-3 as minimum for alma |
Replace depricated Alma 8 GPG key Signed-off-by: ajython <ajython@users.noreply.github.com>
Hello, |
Brilliant work thank you, always nice to be able to merge someone PR rather than add credits. Thank you uk-bolly |
* initial v3.0.0 Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * removed old conflict line Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * tidy up warning on 432 Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * tidy up ec2_checks Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated warning on line 435 Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated prelim and typos Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/ansible-community/ansible-lint: v24.2.0 → v24.2.1](ansible/ansible-lint@v24.2.0...v24.2.1) * March 24 updates (#356) * added conditional to user password check #354 thanks to @bbaassssiiee Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated logic to check root passwd locked Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * lint and audit order change Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated for documentation format Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Allow for a local site policy for the openSSH server. (#358) If changes to the system-wide crypto policy are required to meet local site policy for the openSSH server, these changes should be done with a sub-policy assigned to the system-wide crypto policy. The role defaults can be overridden by the user's vars. The user should implement a .pmod file, and add its basename to `rhel8cis_allowed_crypto_policies_modules`. The role vars are harder to change due to the 21 priority levels of Ansible. Signed-off-by: Bas Meijer <bas.meijer@enexis.nl> * Issues March24 (#366) * #359 addressed thanks to @bbaassssiiee Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * sysctl matches requirement & handler added Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * container updated and cautions updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * issues #360 addressed thanks to @bbaassssiiee Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Added #361 ensure local interface on 3.4.2.2 Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * issue #363 addressed Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * variable naming and lint Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * variable naming and lint Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated handler Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * variable naming and lint updates Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * fix issues with pam_unix Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * added extra options Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * issue #365 addressed Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * fixed commenting alternate file Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated var name to discovered Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * renamed variable tomake it clearer Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * fix typo Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated discovered variable naming Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated variable naming Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * [pre-commit.ci] pre-commit autoupdate (#367) updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit autoupdate (#368) updates: - [github.com/ansible-community/ansible-lint: v24.2.1 → v24.2.2](ansible/ansible-lint@v24.2.1...v24.2.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * updated for audit and url alignment (#370) Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * [pre-commit.ci] pre-commit autoupdate (#372) updates: - [github.com/Yelp/detect-secrets: v1.4.0 → v1.5.0](Yelp/detect-secrets@v1.4.0...v1.5.0) - [github.com/gitleaks/gitleaks: v8.18.2 → v8.18.3](gitleaks/gitleaks@v8.18.2...v8.18.3) - [github.com/ansible-community/ansible-lint: v24.2.2 → v24.6.0](ansible/ansible-lint@v24.2.2...v24.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * use RHEL8 chrony.conf (#371) Signed-off-by: Tomáš Kuba <tom.kuba@gmail.com> * Update Alma 8 GPG Key (#369) * Update Alma 8 GPG Key Update AlmaLinux.yml Signed-off-by: ajython <ajython@users.noreply.github.com> * Update AlmaLinux.yml Replace depricated Alma 8 GPG key Signed-off-by: ajython <ajython@users.noreply.github.com> --------- Signed-off-by: ajython <ajython@users.noreply.github.com> * May 24 updates (#376) * updated path to match disa for audit tools Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated dict control Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated nullok logic Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated typos Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated typ thanks to @msachikanta Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * [pre-commit.ci] pre-commit autoupdate (#383) updates: - [github.com/gitleaks/gitleaks: v8.18.3 → v8.18.4](gitleaks/gitleaks@v8.18.3...v8.18.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * updated known issues thanks to @fgierlinger Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Interactive users logic and workflow (#385) * interactive user vars updates Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * improved conditionals checks Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Tidy up titles Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated with latest devel Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * removed file not required Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * improved logic for /dev/null home dirs Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Updated workflow to new runner Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> Signed-off-by: Bas Meijer <bas.meijer@enexis.nl> Signed-off-by: Tomáš Kuba <tom.kuba@gmail.com> Signed-off-by: ajython <ajython@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bas <bas.meijer@enexis.nl> Co-authored-by: tomkuba <tomkuba@users.noreply.github.com> Co-authored-by: ajython <ajython@users.noreply.github.com> Co-authored-by: Fred W <112580756+frederickw082922@users.noreply.github.com>
Update AlmaLinux.yml
Overall Review of Changes:
Following Alma 8 GPG change, the new GPG key needs updating.
Issue Fixes:
Please list (using linking) any open issues this PR addresses
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
N/A