Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated 1.2.2-1.2.5 improved regex #425 #426

Merged
merged 1 commit into from
Nov 12, 2024
Merged

updated 1.2.2-1.2.5 improved regex #425 #426

merged 1 commit into from
Nov 12, 2024

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:
Added fix for issue 425

Issue Fixes:
#425

How has this been tested?:
Manual and pipeline

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly requested a review from georgenalen November 11, 2024 15:25
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit 8124741 into devel Nov 12, 2024
4 checks passed
@uk-bolly uk-bolly deleted the issue_425 branch November 12, 2024 13:48
Copy link

@exZACHly exZACHly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked one potential typo on line 75

@@ -72,7 +72,7 @@
- name: "1.2.3 | PATCH | Ensure repo_gpgcheck is globally activated | Update yum.repos"
ansible.builtin.replace:
name: "{{ item.path }}"
regexp: "^repo_gpgcheck=0"
regexp: ^repo_gpgcheck\s*=\s*0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a rogue quote here, at the very end of line 75: regexp: ^repo_gpgcheck\s*=\s*0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants