Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating some things to clean up for final review #10

Merged
merged 14 commits into from
Nov 22, 2024

Conversation

djdanielsson
Copy link
Contributor

@djdanielsson djdanielsson commented Nov 15, 2024

making some changes for the final review

@djdanielsson djdanielsson marked this pull request as draft November 15, 2024 16:27
djdanielsson and others added 2 commits November 15, 2024 18:38
	new file:   changelogs/config.yaml
	new file:   changelogs/fragments/.keep
@djdanielsson djdanielsson marked this pull request as ready for review November 15, 2024 19:08
@djdanielsson
Copy link
Contributor Author

not positive I changed everything in release workflow to make it work in this repo but should be close

@djdanielsson
Copy link
Contributor Author

./sigh because the upstream and downstream of the collection dependencies being named differently is causing complications in the CI, I have asked the dev team how to fix it but idk it might not be simple which then would require this collection to maintain it's own set of tests and keeping updating it to match

@djdanielsson
Copy link
Contributor Author

giving up on the devtools GitHub actions

@djdanielsson
Copy link
Contributor Author

CI won't work due to GitHub limitations, idk how to fix it when this collection requires a downstream collection

@guidograzioli
Copy link
Member

Do not worry about the failure, it is because a PR cannot read the github secrets (ie. the token). The changeset is otherwise good to me, but I'd had preferred to use our "own" changelog workflow to generate it using the github PR titles instead of having to use PR fragments. However, LGTM

@guidograzioli guidograzioli merged commit 7003b1f into ansible-middleware:main Nov 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants