models: break up the dependency between the user and the payload #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
goneri/models-break-up-the-dependency-between-the-user-and-the-payload_27317
branch
from
a9d5503
to
3e4d2bf
Compare
manstis
previously approved these changes
May 28, 2024
robinbobbitt
previously requested changes
May 28, 2024
goneri
force-pushed
the
goneri/models-break-up-the-dependency-between-the-user-and-the-payload_27317
branch
from
3e4d2bf
to
ada71cc
Compare
Pass the `request` object as the first `infer()` parameter and remove the user related information from the payload.
goneri
force-pushed
the
goneri/models-break-up-the-dependency-between-the-user-and-the-payload_27317
branch
from
ada71cc
to
577237b
Compare
|
That was just a (self inflicted) rebased. |
goneri
deleted the
goneri/models-break-up-the-dependency-between-the-user-and-the-payload_27317
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the
requestobject as the firstinfer()parameter and remove theuser related information from the payload.