Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-24179 - creating git metadata task #1072

Closed
wants to merge 1 commit into from

Conversation

SiddharthRajaraman
Copy link
Contributor

@SiddharthRajaraman SiddharthRajaraman commented May 28, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-24179

Description

Testing

Steps to test

  1. Pull down the PR
  2. ...
  3. ...

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@SiddharthRajaraman SiddharthRajaraman force-pushed the commit-timestamp branch 2 times, most recently from 79907fb to 3db49f6 Compare May 28, 2024 19:39
@SiddharthRajaraman SiddharthRajaraman changed the title creating git metadata task AAP-24179 - creating git metadata task May 28, 2024
set -euo pipefail
cd "$(workspaces.source.path)/source"

echo $(date -d @$(git log -1 --format=%at) "+%Y%m%d%H%M") > $(results.commit-timestamp.path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can achieve the same with one single command:

git log -1 --format=%ad --date "format:%Y%m%d%H%M" > $(results.commit-timestamp.path)

@SiddharthRajaraman SiddharthRajaraman force-pushed the commit-timestamp branch 4 times, most recently from 8e57609 to 2429648 Compare May 29, 2024 19:27
goneri
goneri previously approved these changes May 30, 2024
@goneri
Copy link
Contributor

goneri commented May 30, 2024

+1 but I would prefer if @jameswnl can also take a look.

@SiddharthRajaraman SiddharthRajaraman added pr-deployment To trigger a deployment based on this PR's image and removed pr-deployment To trigger a deployment based on this PR's image labels May 30, 2024
@SiddharthRajaraman SiddharthRajaraman added pr-deployment To trigger a deployment based on this PR's image and removed pr-deployment To trigger a deployment based on this PR's image labels May 31, 2024
@ansible ansible deleted a comment from jameswnl May 31, 2024
@SiddharthRajaraman SiddharthRajaraman added the pr-deployment To trigger a deployment based on this PR's image label May 31, 2024
@jameswnl
Copy link
Contributor

PR Deployment created in namespace wisdom-pr-1072

Look up the wisdom-service url in the cluster

@SiddharthRajaraman SiddharthRajaraman marked this pull request as draft May 31, 2024 15:41
@SiddharthRajaraman SiddharthRajaraman removed the pr-deployment To trigger a deployment based on this PR's image label May 31, 2024
@SiddharthRajaraman SiddharthRajaraman deleted the commit-timestamp branch June 20, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants