Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-25344: AAP 2.5 Gateway SSO for Lightspeed #1299

Merged
merged 1 commit into from
Sep 13, 2024
Merged

AAP-25344: AAP 2.5 Gateway SSO for Lightspeed #1299

merged 1 commit into from
Sep 13, 2024

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Sep 12, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-25344

Description

Fixed links for AAP 2.5 Gateway API. Now it supports both AAP Controller and AAP Gateway.

Testing

Steps to test

  1. Pull down the PR
  2. Ran in on-prem mode
  3. Configure AAP 2.5 Gateway
  4. Log in into Lightspeed using AAP Gateway
  5. Configure AAP 2.4/2.5 Controller
  6. Log in into Lightspeed using AAP Controller

Scenarios tested

Described above (used AAP 2.5 Gateway and Controller)

Production deployment

  • This code change is ready for production on its own

@hasys hasys requested a review from jameswnl September 12, 2024 15:57
@BrennanPaciorek
Copy link

BrennanPaciorek commented Sep 12, 2024

These changes work for me (I only e2e tested with AAP 2.5, verified AAP 2.4 url maps to /api/o/). Should any documentation detailing what to set AAP_API_URL to be written?

@hasys
Copy link
Contributor Author

hasys commented Sep 13, 2024

Re-pushed to sign the commit, nothing changed. Waiting until all checks are green and merging. Thank you @jameswnl @omaciel!

@hasys hasys closed this Sep 13, 2024
@hasys hasys reopened this Sep 13, 2024
Copy link

sonarcloud bot commented Sep 13, 2024

@hasys hasys merged commit 04e87cb into main Sep 13, 2024
17 of 18 checks passed
@hasys hasys deleted the on-prem branch September 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants