Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-31326: Add OrgName to the Marketing report #1304

Merged

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Sep 16, 2024

No description provided.

manstis
manstis previously approved these changes Sep 16, 2024
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Personally, I'd have placed the new column after "Org ID"; but there's nothing in the JIRA.

@manstis
Copy link
Contributor

manstis commented Sep 16, 2024

Vulnerabilities scan fix can be found here: #1303

@goneri goneri force-pushed the goneri/AAP-31326-Add-OrgName-to-the-Marketing-report_26860 branch from 8f18bb6 to 5b135c4 Compare September 16, 2024 17:24
@goneri goneri force-pushed the goneri/AAP-31326-Add-OrgName-to-the-Marketing-report_26860 branch from 5b135c4 to 6495e36 Compare September 16, 2024 17:41
@goneri goneri force-pushed the goneri/AAP-31326-Add-OrgName-to-the-Marketing-report_26860 branch from 6495e36 to e6b6829 Compare September 16, 2024 17:42
Copy link

sonarcloud bot commented Sep 16, 2024

@goneri goneri requested a review from manstis September 16, 2024 18:05
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goneri goneri merged commit ba0feae into main Sep 16, 2024
12 checks passed
@goneri goneri deleted the goneri/AAP-31326-Add-OrgName-to-the-Marketing-report_26860 branch September 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants