Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-31447: user report, add the Email column #1314

Merged
merged 1 commit into from
Sep 19, 2024
Merged

AAP-31447: user report, add the Email column #1314

merged 1 commit into from
Sep 19, 2024
+23 −10

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Sep 17, 2024

No description provided.

manstis
manstis previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goneri goneri force-pushed the goneri/AAP-31447-user-report-add-the-Email-column_1191 branch from bcaaee6 to 469423c Compare September 18, 2024 21:29
@goneri goneri requested a review from manstis September 18, 2024 21:41
@goneri goneri force-pushed the goneri/AAP-31447-user-report-add-the-Email-column_1191 branch from 469423c to a30deb0 Compare September 18, 2024 21:42
manstis
manstis reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Rather cryptic cpt.. but I understand what it's doing.

@goneri
Copy link
Contributor Author

goneri commented Sep 19, 2024

LGTM 👍

Rather cryptic cpt.. but I understand what it's doing.

Let's me rename this variable.

@goneri
AAP-31447: Marketing report (#1313)
e0135a0 
Move the "Organization name" column and remove the "Trial expired_at" column.
@goneri goneri force-pushed the goneri/AAP-31447-user-report-add-the-Email-column_1191 branch from a30deb0 to e0135a0 Compare September 19, 2024 13:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

manstis
manstis approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@goneri goneri merged commit 5042dff into main Sep 19, 2024
12 checks passed
@goneri goneri deleted the goneri/AAP-31447-user-report-add-the-Email-column_1191 branch September 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manstis manstis manstis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneri @manstis