Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set chatbot message timestamp when a message is received #1384

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Set chatbot message timestamp when a message is received #1384

merged 1 commit into from
Nov 6, 2024

Conversation

TamiTakamiya
Copy link
Contributor

Jira Issue: https://issues.redhat.com/browse/AAP-35211

Description

Add a timestamp to each message when it is received. Othewise, timestamps are dynamically generated at runtime and vary at every re-draw.

Testing

Steps to test

  1. Pull down the PR
  2. Run the chatbot locally and see message timestamps stay in fixed values.

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@TamiTakamiya TamiTakamiya changed the title Set timestamp when a message is received Set chatbot message timestamp when a message is received Nov 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

omaciel
omaciel approved these changes Nov 6, 2024
View reviewed changes
Copy link

@omaciel omaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TamiTakamiya TamiTakamiya merged commit df2d1f8 into main Nov 6, 2024
11 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/AAP-35211/timestamp-issue branch November 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omaciel omaciel omaciel approved these changes

@justjais justjais Awaiting requested review from justjais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TamiTakamiya @omaciel