-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed UI-focused user docs from AWX. #15641
Conversation
This reverts commit 1214b00.
Hey @tvo318 Looks like there is some funky indentation in the left nav: |
I think the left nav is off because "Release Notes" is an external link instead of a local RST file. could you try creating a file called something like
then put that in the toctree before
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @tvo318
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A couple of conf.py suggestions you could consider.
@@ -8,10 +8,10 @@ | |||
sys.path.insert(0, os.path.abspath('./rst/rest_api/_swagger')) | |||
|
|||
project = u'Ansible AWX' | |||
copyright = u'2023, Red Hat' | |||
copyright = u'2024, Red Hat' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RH legal said we don't need to have a date in the copyright statement. So you can pull 2024 out of this and never have to edit it again! Also if this is opensource, we may want a more generic owner. like copyright = "AWX project contributors"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this is in a subsequent PR.
author = u'Red Hat' | ||
|
||
pubdateshort = '2023-08-04' | ||
pubdateshort = '2024-11-22' | ||
pubdate = datetime.strptime(pubdateshort, '%Y-%m-%d').strftime('%B %d, %Y') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could experiment with removing this pubdate info and pubdateshort with something like this which we use on the core/package docs... and ... never update it again :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed, let's do this is in a subsequent PR.
SUMMARY
Removed user docs with UI-focus from AWX as part of the AWX modernization efforts.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
latest