Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove git req from final requirements.txt #15644

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Remove git req from final requirements.txt #15644

wants to merge 2 commits into from

Conversation

chrismeyersfsu
Copy link
Member

SUMMARY

requirements_git.txt entries shouldn't end up in requirements.txt

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
devel
ADDITIONAL INFORMATION

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 18, 2024
@AlanCoding
Copy link
Member

Link #15605 that @TheRealHaoLiu put up. Taking it at face-value, that seems to be a workable approach.

Unless there's another change in https://github.com/ansible/awx_plugins.interfaces to support this, I don't think this works.

@webknjaz
Copy link
Member

I would recommend maintaining a full list of abstract deps in a separate place and generating pins from that. The source URL limitations can be set up as pip constraints and augment that instead of special-casing several dependencies by pretending they aren't there.

@webknjaz
Copy link
Member

@AlanCoding I was thinking along the lines of #15649

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@webknjaz
Copy link
Member

@AlanCoding I was thinking along the lines of #15649

Urgh.. it appears I messed up the commit there. Re-pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealHaoLiu TheRealHaoLiu Awaiting requested review from TheRealHaoLiu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrismeyersfsu @AlanCoding @webknjaz