Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML fixes #654

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

SAML fixes #654

wants to merge 3 commits into from
+145 −2

Conversation

relrod
Copy link
Member

@relrod relrod commented Nov 21, 2024 •
edited by john-westcott-iv
Loading

This ensures that the firstname/lastname/email/etc attributes that are entered into the IdP fields are returned out of the assertion. If additional information is needed admins will have to either set GET_ALL_EXTRA_DATA to get it all or they can set EXTRA_DATA to get specific fields.

@relrod @john-westcott-iv
Backend's ID_KEY might be None
b00db70 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod @john-westcott-iv
Store essential SAML attrs by default
ba3e77a 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod @john-westcott-iv
Never fatal.
c1d35eb 
Signed-off-by: Rick Elrod <rick@elrod.me>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-westcott-iv john-westcott-iv Awaiting requested review from john-westcott-iv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@relrod