Add configuration config #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekans
approved these changes
Oct 19, 2023
| class CodeAnalysisTest extends TestCase | ||
| { | ||
| #[Test] | ||
| public function testNoAnnotationTest(): void |
There was a problem hiding this comment.
I'm not sure tests are right place to check the annotation. Can we add this when creating a commit, e.g. using GrumPHP?
There was a problem hiding this comment.
GrumPHP can be skipped.
Wiktor6
force-pushed
the
add-configuration
branch
from
b5992a7
to
10b1b4d
Compare
malarzm
reviewed
Oct 20, 2023
| @@ -4,9 +4,9 @@ | |||
| "type": "symfony-bundle", | |||
| "license": "MIT", | |||
| "require": { | |||
| "php": "8.*", | |||
| "php": ">=8.1", | |||
There was a problem hiding this comment.
I'm against such notation, this in fact promises the lib will work with PHP 9, 10, 15, and whatnot. We have no idea whether that's true
malarzm
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration config.