Change endpoint #5
Conversation
yekovalenkoa
force-pushed
the
change-endpoint
branch
2 times, most recently
from
64ddbb5
to
82c7b65
Compare
yekovalenkoa
force-pushed
the
change-endpoint
branch
3 times, most recently
from
d05db85
to
ab6b341
Compare
yekovalenkoa
force-pushed
the
change-endpoint
branch
from
ab6b341
to
d718cf3
Compare
| public readonly string $street, | ||
| public readonly string $streetNo, | ||
| public readonly string $zipCode, | ||
| public readonly string $floor, |
There was a problem hiding this comment.
Shouldn't this property be nullable? Otherwise, will it default to an empty string?
There was a problem hiding this comment.
It is an empty string by default
| $data['data'], | ||
| ); | ||
|
|
||
| return new self( |
There was a problem hiding this comment.
Sure, I changed it
The last tag/release 1.0.1 is the same as |
composer.json
Outdated
| "symfony/property-access": "6.4.*", | ||
| "symfony/property-info": "6.4.*", | ||
| "symfony/serializer": "6.4.*", | ||
| "webmozart/assert": "^1.11" |
There was a problem hiding this comment.
if this is not require for this PR don't bump min versions in requiresection
This is public library, maybe someone has symfony 6.1 for example
src/Resources/config/services.yaml
Outdated
| Answear\FanCourierBundle\Logger\FanCourierLogger: | ||
| shared: false | ||
|
|
||
| Answear\FanCourierBundle\Client\RequestTransformerInterface: '@Answear\FanCourierBundle\Client\RequestTransformer' | ||
| Answear\FanCourierBundle\Client\RequestTransformerInterface: '@Answear\FanCourierBundle\Client\RequestTransformer' |
|
|
||
| public function supportsNormalization($data, $format = null): bool | ||
| { | ||
| return is_object($data) && $this->isEmptyClass($data); |
There was a problem hiding this comment.
Is this normalizer necessary?
Why not `https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php
There was a problem hiding this comment.
I checked this, and indeed no normalizer is needed for normalizing requests.
No description provided.