refactor PHP 8.1 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yekovalenkoa
force-pushed
the
refactor-php-81
branch
2 times, most recently
from
88acf80
to
ff5dd20
Compare
yekovalenkoa
force-pushed
the
refactor-php-81
branch
from
ff5dd20
to
602ba87
Compare
Wiktor6
approved these changes
Feb 1, 2024
lukasz-falda
reviewed
Feb 1, 2024
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "roave/security-advisories": "dev-master", | ||
| "phpunit/phpunit": "^9.6.16", |
There was a problem hiding this comment.
maybe you can bump to 10?
| excludePaths: | ||
| - src/Tests/* | ||
| - tests/* |
There was a problem hiding this comment.
don't exclude tests paths if you don't have to
#whatever
| @@ -94,7 +94,7 @@ private function getCommand(): FindPoints | |||
| return new FindPoints($this->client, new Serializer()); | |||
| } | |||
|
|
|||
| private function getSuccessfulBody(): string | |||
| private function getSuccessfulBody(): string|false | |||
There was a problem hiding this comment.
If we expect string as return leave string only.
You can throw exception on method if you wish
yekovalenkoa
force-pushed
the
refactor-php-81
branch
from
2221633
to
5adf2f0
Compare
lukasz-falda
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.