Merge pull request #9 from answear/handle-empty-response-in-detectByF…

…eature Handle empty response in SearchByFeature
answear · Nov 30, 2021 · f35552f · f35552f
2 parents c0b8021 + ea7535d
commit f35552f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Response/SearchByFeatureResponse.php b/src/Response/SearchByFeatureResponse.php
@@ -19,6 +19,10 @@ private function __construct(array $uids)
 
     public static function fromArray(array $response): SearchByFeatureResponse
     {
+        if (!isset($response[0]['products']) || !is_array($response[0]['products'])) {
+            throw new MalformedResponse('Empty result', $response);
+        }
+
         try {
             $products = $response[0]['products'];
             $responseUids = array_map(

diff --git a/tests/Unit/Service/SearchByImageClientSearchByFeatureTest.php b/tests/Unit/Service/SearchByImageClientSearchByFeatureTest.php
@@ -83,7 +83,7 @@ public function responseWithoutProducts(): void
         $this->guzzleHandler->append(new Response(200, [], $this->prepareNotProperResponse()));
 
         $this->expectException(MalformedResponse::class);
-        $this->expectExceptionMessage('Undefined index: products');
+        $this->expectExceptionMessage('Empty result');
 
         $this->client->searchByFeature(self::FEATURE_ID, self::LABEL);
     }