Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and sort imports #285

Merged
merged 1 commit into from
Aug 26, 2024
Merged

update and sort imports #285

merged 1 commit into from
Aug 26, 2024

Conversation

gmalinve
Copy link
Collaborator

No description provided.

@gmalinve gmalinve self-assigned this Aug 23, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 23, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment.
Seems like this repo is not leveraging the pre-commit.ci, we should update it.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.65%. Comparing base (f762a3d) to head (c6a0f17).

Files Patch % Lines
src/ansys/aedt/toolkits/antenna/backend/api.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          12       12           
  Lines        3262     3262           
=======================================
  Hits         2892     2892           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalinve gmalinve merged commit 0866118 into main Aug 26, 2024
22 checks passed
@gmalinve gmalinve deleted the refacto/update_imports branch August 26, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants