Correctly pass shell layer argument. #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unit of sweeping phase operator
| @@ -266,7 +266,7 @@ def _create_sweeping_phase_workflow( | |||
| raise ValueError("Argument sweeping_phase must be a float.") | |||
| sweeping_op = create_operator_callable(name="sweeping_phase_fc") | |||
| sweeping_op.connect(2, sweeping_phase) | |||
There was a problem hiding this comment.
Not sure why this only popped up now. Probably this workflow is not tested otherwise.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
==========================================
- Coverage 85.17% 85.13% -0.04%
==========================================
Files 52 52
Lines 5201 5201
==========================================
- Hits 4430 4428 -2
- Misses 771 773 +2 |
cbellot000
approved these changes
Dec 19, 2024
janvonrickenbach
deleted the
jvonrick/pass_shell_layer_arguments_correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unit of sweeping phase operator