-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a ton of bugs (2 still left as an exercise) #78
Open
rofl0r
wants to merge
17
commits into
antirez:master
Choose a base branch
from
rofl0r:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 69b3ad8 - Browse repository at this point
Copy the full SHA 69b3ad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c97ca0e - Browse repository at this point
Copy the full SHA c97ca0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 939da83 - Browse repository at this point
Copy the full SHA 939da83View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b7cda - Browse repository at this point
Copy the full SHA f5b7cdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d40830 - Browse repository at this point
Copy the full SHA 2d40830View commit details -
Write entire highlight string for a single-line comment
Was writing `size` chars but the `hl` array was allocated as `rsize` chars.
Configuration menu - View commit details
-
Copy full SHA for 48a0e1a - Browse repository at this point
Copy the full SHA 48a0e1aView commit details -
Avoid stepping past line end in incomplete string when \ is last char
With `'\` or `"...\` as the last characters on the line, `HL_STRING` could be written beyond the allocated size of the `hl` array, causing memory corruption and SEGV.
Configuration menu - View commit details
-
Copy full SHA for 5e71a2e - Browse repository at this point
Copy the full SHA 5e71a2eView commit details -
Avoid invalid memory access if rest of line is shorter than some keyword
The test for a keyword would try to read the entire length of each keyword from the line position even if the rest of the line was too short to contain that keyword. A PR was already submitted for this but the author closed it before it could be merged.
Configuration menu - View commit details
-
Copy full SHA for 2164746 - Browse repository at this point
Copy the full SHA 2164746View commit details -
The function `editorRowHasOpenComment()` used its own definition of a closing multiline comment and duplicated the `hl_oc` member of `struct erow`. Change to use the latter throughout and thus respect the selected syntax definition.
Configuration menu - View commit details
-
Copy full SHA for c4a4d4c - Browse repository at this point
Copy the full SHA c4a4d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3797b2b - Browse repository at this point
Copy the full SHA 3797b2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b478873 - Browse repository at this point
Copy the full SHA b478873View commit details -
implement proper handling of DEL key
del key used to behave just like backspace. commit is based on d-e-h-i-o@799c743 but works on first char in file and doesnt crash program on last.
Configuration menu - View commit details
-
Copy full SHA for 3f29b6a - Browse repository at this point
Copy the full SHA 3f29b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88adc95 - Browse repository at this point
Copy the full SHA 88adc95View commit details -
remove python multiline comments
since python multiline string/comments start and end with the same sequence, kilo is unable to figure out which is which once one removes either one of the start or end markers of the section. dealing with this would require a quite more elaborate engine than currently implement, or doing a new syntax scan over the entire file.
Configuration menu - View commit details
-
Copy full SHA for 00de72e - Browse repository at this point
Copy the full SHA 00de72eView commit details
Commits on Apr 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a3844aa - Browse repository at this point
Copy the full SHA a3844aaView commit details -
don't redraw entire screen if we move cursor within visible area
for a cursor move that doesnt result in any scrolling, we now simply update cursor position (and col/row in status bar) to remove the nasty flickering caused by kilo on xterm when redrawing the entire screen everytime a cursor is moved. there's still a bug when moving cursor horizontally inside a long line, in that it's not detected that the screen needs redraw. i'll leave the fix to someone else as i'm done with this buggy editor.
Configuration menu - View commit details
-
Copy full SHA for 6328119 - Browse repository at this point
Copy the full SHA 6328119View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92b6032 - Browse repository at this point
Copy the full SHA 92b6032View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.