Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a ton of bugs (2 still left as an exercise) #78

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Commits on Apr 20, 2021

  1. Configuration menu
    Copy the full SHA
    69b3ad8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c97ca0e View commit details
    Browse the repository at this point in the history
  3. Handling of HOME and END

    j0hnlittle authored and rofl0r committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    939da83 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f5b7cda View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2d40830 View commit details
    Browse the repository at this point in the history
  6. Write entire highlight string for a single-line comment

    Was writing `size` chars but the `hl` array was allocated as `rsize` chars.
    dirkf authored and rofl0r committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    48a0e1a View commit details
    Browse the repository at this point in the history
  7. Avoid stepping past line end in incomplete string when \ is last char

    With `'\` or `"...\` as the last characters on the line, `HL_STRING`
    could be written beyond the allocated size of the `hl` array, causing
    memory corruption and SEGV.
    dirkf authored and rofl0r committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    5e71a2e View commit details
    Browse the repository at this point in the history
  8. Avoid invalid memory access if rest of line is shorter than some keyword

    The test for a keyword would try to read the entire length of each keyword
    from the line position even if the rest of the line was too short to
    contain that keyword.
    A PR was already submitted for this but the author closed it before
    it could be merged.
    dirkf authored and rofl0r committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2164746 View commit details
    Browse the repository at this point in the history
  9. fix multiline comments

    The function `editorRowHasOpenComment()` used its own definition of a
    closing multiline comment and duplicated the `hl_oc` member of `struct erow`.
    Change to use the latter throughout and thus respect the selected syntax
    definition.
    dirkf authored and rofl0r committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c4a4d4c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3797b2b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b478873 View commit details
    Browse the repository at this point in the history
  12. implement proper handling of DEL key

    del key used to behave just like backspace.
    commit is based on d-e-h-i-o@799c743
    but works on first char in file and doesnt crash program on last.
    rofl0r committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3f29b6a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    88adc95 View commit details
    Browse the repository at this point in the history
  14. remove python multiline comments

    since python multiline string/comments start and end with the same
    sequence, kilo is unable to figure out which is which once one removes
    either one of the start or end markers of the section.
    dealing with this would require a quite more elaborate engine than
    currently implement, or doing a new syntax scan over the entire file.
    rofl0r committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    00de72e View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Configuration menu
    Copy the full SHA
    a3844aa View commit details
    Browse the repository at this point in the history
  2. don't redraw entire screen if we move cursor within visible area

    for a cursor move that doesnt result in any scrolling, we now simply update
    cursor position (and col/row in status bar) to remove the nasty flickering
    caused by kilo on xterm when redrawing the entire screen everytime a cursor
    is moved.
    there's still a bug when moving cursor horizontally inside a long line, in
    that it's not detected that the screen needs redraw.
    i'll leave the fix to someone else as i'm done with this buggy editor.
    rofl0r committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    6328119 View commit details
    Browse the repository at this point in the history
  3. add BUGS

    rofl0r committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    92b6032 View commit details
    Browse the repository at this point in the history