feat: 构建注入version #1996
Merged
feat: 构建注入version #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zengyue
reviewed
Sep 13, 2024
packages/f2/src/index.ts
Outdated
| @@ -4,3 +4,6 @@ export * from '@antv/f-engine'; | |||
| export { default as Chart, ChartProps } from './chart'; | |||
| export { Scale, ScaleConfig } from './deps/f2-scale/src'; | |||
| export * from './components'; | |||
|
|
|||
| import info from '../package.json'; | |||
| export default { version: info?.version }; | |||
There was a problem hiding this comment.
这个不要直接 import package, 最好通过构建注入进来
There was a problem hiding this comment.
有道理，我看看有没有对应的插件
tangying1027
force-pushed
the
feat-version
branch
from
9f50927
to
9467a81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change