-
-
Notifications
You must be signed in to change notification settings - Fork 23.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization of ownerAffiliations with parameter #1122
base: master
Are you sure you want to change the base?
Conversation
@developStorm is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
@developStorm Thanks a lot for this pull request it works perfectly on my fork. |
Thank you so much! I find this useful 😀 |
What is blocking this from being merged? |
@developStorm I reviewed your pull request and it looks good to me. I however noticed that the tests were broken. I created a pull request to fix this on your branch developStorm#1. @anuraghazra Sorry for the PR waterfall. I, however, found too many changes for me to use the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this solution is more in line with #1 (comment).
Apart from these changes, I think the new argument should be added to the documentation before this pull request can be merged. |
Automated Theme Preview
title_color: Hi, thanks for the theme contribution, please read our theme contribution guidelines. We are currently only accepting color combinations from any VSCode theme or themes which have good color combination to minimize bloating the themes collection.
|
f255277
to
b07ce83
Compare
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 96.90% 96.84% -0.07%
==========================================
Files 22 22
Lines 3882 3956 +74
Branches 337 341 +4
==========================================
+ Hits 3762 3831 +69
- Misses 118 123 +5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
@developStorm I created #2277 as a replacement for #1122. Please take a look and close this PR if you think it suits your needs. |
86aafe8
to
8bc69e7
Compare
@anuraghazra I'm okay with merging this since it is what the community wants. As far as I know, it will not deplete our PATs since it uses the same number of GraphQL points as the master branch. It will, however, not give accurate stats results on the Public instance unless
|
Replaced by #2459 since I don't want to break @developStorm's master branch when I make a change. |
This commit fixes a small error in the stats-fetcher that caused the `exclude_repo` parameter values to be seen as the `ownerAffiliation` inputs.
See #1 (comment). #1